Skip to content

Fix temp file cleanup and reorganized temp dir structure #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 17, 2023
Merged

Fix temp file cleanup and reorganized temp dir structure #154

merged 5 commits into from
Aug 17, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 21, 2023

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

  • Fix the cleanup of temporary files created during language server execution.
  • All temporary files are now created under the same sub-directory of tmp

What is the current behavior?

Language server temp directory:    C:\Users\cmagl\AppData\Local\Temp\system-includes-0f3fe3.clangd
Language server build path:        C:\Users\cmagl\AppData\Local\Temp\arduino-language-server3185134839
Language server build sketch root: C:\Users\cmagl\AppData\Local\Temp\arduino-language-server3185134839\sketch
Language server FULL build path:   C:\Users\cmagl\AppData\Local\Temp\arduino-language-server795682186

What is the new behavior?

  • All temporary files are removed on exit.
  • All temporary files are created under the same subdir of TMP
Language server temp directory:    C:\Users\cmagl\AppData\Local\Temp\arduino-language-server2854144105\system-includes-0f3fe3.clangd
Language server build path:        C:\Users\cmagl\AppData\Local\Temp\arduino-language-server2854144105\build
Language server build sketch root: C:\Users\cmagl\AppData\Local\Temp\arduino-language-server2854144105\build\sketch
Language server FULL build path:   C:\Users\cmagl\AppData\Local\Temp\arduino-language-server2854144105\fullbuild

Other information:
Fix #145

@cmaglie cmaglie self-assigned this Mar 21, 2023
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 21, 2023
@umbynos umbynos mentioned this pull request May 15, 2023
Closed
3 tasks
cmaglie added 5 commits August 17, 2023 14:52
@cmaglie
Create a detached process to clean up tmp dirs on closing
923dbd5 
The temp dir cleanup is done on the "exit" notification.
BTW, if the OS/system is too slow, the language server may be killed by the
IDE if it takes too long to clean up temporary build directories.

To avoid it a new detached process is created with the only purpose to
remove the temporary directories. Since it's detached it will run even
after the parent process exits.
@cmaglie
Keep all language-server tmp files inside a single subdir
11be750
@cmaglie
Tell clangd to write tmp files inside the language server tmp dir
ffb735c 
Fix #145
@cmaglie
Fixed an unrelated linter error
84f3847
@cmaglie
Added safety check
ca7d9ae
@cmaglie cmaglie force-pushed the fix-temp-file-cleanup branch from 2760510 to ca7d9ae Compare August 17, 2023 12:52
@cmaglie cmaglie merged commit 4752595 into main Aug 17, 2023
@cmaglie cmaglie deleted the fix-temp-file-cleanup branch August 17, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@umbynos umbynos Awaiting requested review from umbynos

@per1234 per1234 Awaiting requested review from per1234

@alessio-perugini alessio-perugini Awaiting requested review from alessio-perugini

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporary files are not cleaned up
2 participants
@cmaglie @MatteoPologruto